Skip to content

fix(Code References): Very slow data migration#7555

Merged
khvn26 merged 4 commits into
mainfrom
fix/code-references-migration
May 20, 2026
Merged

fix(Code References): Very slow data migration#7555
khvn26 merged 4 commits into
mainfrom
fix/code-references-migration

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented May 20, 2026 •
edited
Loading

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Follow up to #7463

While the original migration takes <30s on local with same data, it blew up in production. This is an attempt to unblock this migration by making it faster.

How did you test this code?

Local tests using a code references data dump from production.

@emyller emyller requested a review from a team as a code owner May 20, 2026 16:31
@emyller emyller requested review from khvn26 and removed request for a team May 20, 2026 16:31
claude[bot]
claude Bot reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 20, 2026 4:55pm
flagsmith-frontend-preview Ignored Ignored Preview May 20, 2026 4:55pm
flagsmith-frontend-staging Ignored Ignored Preview May 20, 2026 4:55pm

Request Review

@emyller emyller changed the title Improve code references migration fix(Code References): Very slow migration May 20, 2026
@emyller emyller changed the title fix(Code References): Very slow migration fix(Code References): Very slow data migration May 20, 2026
@github-actions github-actions Bot added the api Issue related to the REST API label May 20, 2026
@emyller emyller marked this pull request as draft May 20, 2026 16:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7555 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7555 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7555 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7555 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7555 Finished ✅ Results ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.48%. Comparing base (dc60398) to head (0311ea0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7555   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files        1402     1402           
  Lines       53291    53300    +9     
=======================================
+ Hits        52481    52490    +9     
  Misses        810      810

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.9 seconds
commit  7a21289
info  🔄 Run: #16870 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.8 seconds
commit  7a21289
info  🔄 Run: #16870 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  39.6 seconds
commit  7a21289
info  🔄 Run: #16870 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  47.8 seconds
commit  7a21289
info  🔄 Run: #16870 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.5 seconds
commit  086a8b5
info  🔄 Run: #16873 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.9 seconds
commit  086a8b5
info  🔄 Run: #16873 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  37 seconds
commit  086a8b5
info  🔄 Run: #16873 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  36.5 seconds
commit  086a8b5
info  🔄 Run: #16873 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.1 seconds
commit  853fcff
info  🔄 Run: #16874 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.6 seconds
commit  853fcff
info  🔄 Run: #16874 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  40.5 seconds
commit  853fcff
info  🔄 Run: #16874 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.2 seconds
commit  853fcff
info  🔄 Run: #16874 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.2 seconds
commit  0311ea0
info  🔄 Run: #16875 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  55.9 seconds
commit  0311ea0
info  🔄 Run: #16875 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  38.8 seconds
commit  0311ea0
info  🔄 Run: #16875 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  19 passed

Details

stats  19 tests across 15 suites
duration  1 minute, 5 seconds
commit  0311ea0
info  🔄 Run: #16875 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026 •
edited
Loading

Visual Regression

19 screenshots compared. See report for details.
View full report

@github-actions github-actions Bot added the fix label May 20, 2026
@emyller emyller self-assigned this May 20, 2026
@emyller emyller marked this pull request as ready for review May 20, 2026 16:43
@github-actions github-actions Bot added fix and removed fix labels May 20, 2026
khvn26
khvn26 previously approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks right to me 👍

@emyller @claude
Fix tests
0311ea0 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@emyller emyller force-pushed the fix/code-references-migration branch from 853fcff to 0311ea0 Compare May 20, 2026 16:55
@github-actions github-actions Bot removed the fix label May 20, 2026
@github-actions github-actions Bot added the fix label May 20, 2026
@khvn26 khvn26 merged commit 4f93bf6 into main May 20, 2026
32 checks passed
@khvn26 khvn26 deleted the fix/code-references-migration branch May 20, 2026 17:44
@flagsmithdev flagsmithdev mentioned this pull request May 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@khvn26 khvn26 khvn26 approved these changes

Assignees

@emyller emyller

Labels

api Issue related to the REST API fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emyller @khvn26